fix(release) publish crates on nearcore release #11318
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VanBarbascu
commented
May 15, 2024
|
|
||
| - name: Checkout nearcore repository | ||
| if: ${{ github.event_name != 'workflow_dispatch'}} | ||
| uses: actions/checkout@v4 |
There was a problem hiding this comment.
@andrei-near, can you confirm that this will pickup the right branch/tag when it is triggered by the release?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11318 +/- ##
==========================================
+ Coverage 71.01% 71.03% +0.01%
==========================================
Files 782 782
Lines 156476 156476
Branches 156476 156476
==========================================
+ Hits 111123 111147 +24
+ Misses 40525 40503 -22
+ Partials 4828 4826 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
This direction looks great to me. I want to highlight that previously we observed the following issues with the release pipeline:
|
nagisa
reviewed
Jun 4, 2024
| @@ -11,20 +13,29 @@ on: | |||
| jobs: | |||
| publish-cargo-crates: | |||
| name: "Publish near-workspaces on crates.io https://crates.io/crates/near-workspaces" | |||
| runs-on: "ubuntu-22.04-16core" | |||
| runs-on: "ubuntu-20.04-16core" | |||
There was a problem hiding this comment.
Is there a reason for reverting this to an older version? IIRC 20.04 is nearing EOL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run the publish crates WF on release.