Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: contracts/gibberish.py nayduck test #11340

Merged
merged 1 commit into from
May 20, 2024
Merged

Conversation

pugachAG
Copy link
Contributor

Fixed by making nodes track all shards.

@pugachAG pugachAG requested a review from a team as a code owner May 17, 2024 19:09
Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.08%. Comparing base (7befdbd) to head (efa7914).
Report is 13 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11340      +/-   ##
==========================================
+ Coverage   71.04%   71.08%   +0.04%     
==========================================
  Files         782      783       +1     
  Lines      156618   156875     +257     
  Branches   156618   156875     +257     
==========================================
+ Hits       111264   111520     +256     
+ Misses      40533    40521      -12     
- Partials     4821     4834      +13     
Flag Coverage Δ
backward-compatibility 0.24% <ø> (-0.01%) ⬇️
db-migration 0.24% <ø> (-0.01%) ⬇️
genesis-check 1.39% <ø> (-0.01%) ⬇️
integration-tests 37.13% <ø> (-0.07%) ⬇️
linux 68.80% <ø> (-0.12%) ⬇️
linux-nightly 70.53% <ø> (+0.01%) ⬆️
macos 52.24% <ø> (-0.08%) ⬇️
pytests 1.61% <ø> (-0.01%) ⬇️
sanity-checks 1.40% <ø> (-0.01%) ⬇️
unittests 65.51% <ø> (+0.03%) ⬆️
upgradability 0.29% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Longarithm Longarithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"tracked_shards": [0]

Side note: maybe we'll have to change it in all nayduck tests once subsets of tracked shards will be supported.

@wacban
Copy link
Contributor

wacban commented May 18, 2024

LGTM, but I wonder if we should be moving in the opposite direction since in SV the default will be single shard tracking. Let's merge as is but I'm curious to hear your thoughts.

@pugachAG
Copy link
Contributor Author

@Longarithm @wacban
I agree that it would be nice to adjust nayduck tests to only track a necessary subset of shard, but I suggest we do that as separate effort.

@pugachAG pugachAG added this pull request to the merge queue May 20, 2024
Merged via the queue into master with commit 9c4ee1c May 20, 2024
29 checks passed
@pugachAG pugachAG deleted the fix-nayduck-gibberish-test branch May 20, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants