Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Component] - Input #264

Open
nickzafiropulos opened this issue Jan 2, 2024 · 0 comments · May be fixed by #321
Open

[Component] - Input #264

nickzafiropulos opened this issue Jan 2, 2024 · 0 comments · May be fixed by #321
Assignees
@marceloFerreira90

Comments

@nickzafiropulos
Copy link

Figma - https://www.figma.com/file/XFbhstkgQFz8ZefAU3w2p4/1.-Quantum-Design-System?type=design&node-id=33-4878&mode=design

Storybook - https://nearform.github.io/quantum/?path=/docs/form-input--docs

  1. There should be two size variants - sm and regular which have different height dimensions (sm = 37px, regular = 42px)
  2. The current implementation has a height of 40px, which is neither sm or regular
  3. Please check the icon sizes (left icon, and the X on the right) - left icon should be 16x16px, right (x) should be 12x12px, but with a clickable area of 24x24px for accessibility
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marceloFerreira90 marceloFerreira90

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: input control sizes and icon sizes nearform/quantum
2 participants
@marceloFerreira90 @nickzafiropulos