-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: input control sizes and icon sizes #321
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for quantum-deploy-previews ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! No comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code wise LGTM
Hello @marceloFerreira90 , as you see in images the only issue is that the height is a little off. It should be of 240px x |
closes: #264
Added both sizes md (42px) and sm (37px)
Reduced the size of the x icon
ensured size of left side icon to be correct
We disabled the HTML Size in line with other libraries (Primer).