refactor: migrate to node test runner #1129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barelyhuman
requested review from
simoneb and
luke88jones
and removed request for
simoneb
barelyhuman
requested review from
simoneb
and removed request for
luke88jones
luke88jones
reviewed
Feb 1, 2024
haven't found one, the one in references is one of the few duplicates about the same error. The workaround of using a newer node version seems to be working based on the following action https://github.com/nearform/the-fastify-workshop/actions/runs/7736673623/job/21094398580 The original action in the repository seems to go on and on and so the workaround works but I do not have any idea about the root cause |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the following to use node test runner instead of Tap
Note
The timeout issue still exists, as it's a problem with node v20 itself and not tap / node test runner.
Workaround for the infinite loop and getting stuck is to use Node 21, which doesn't sit well with the
lts/*rule we have.References
closes: #1128