Skip to content
This repository has been archived by the owner on Oct 4, 2022. It is now read-only.

Fix CLI command name from starter to init #130

Merged
merged 1 commit into from Sep 4, 2018
Merged

Fix CLI command name from starter to init #130

merged 1 commit into from Sep 4, 2018

Conversation

simoneb
Copy link
Member

@simoneb simoneb commented Sep 4, 2018

And show help when wrong command name given

Addresses #122

The problem was with wrong documentation, it mentioned the starter command for the CLI, whereas the right command is init. It would be one option to keep starter, but I think init makes more sense and also matches what other such CLIs are doing, with the exception of some, like create-react-app, which doesn't take any commands because the only thing it does is generate the skeleton project. I presume we want commands here because at some point titus will do more than just generating the skeleton.

Also added a fallback to show the help when the command is not recognized, as opposed to showing nothing which is not very helpful. Inspired from here

And show help when wrong command name given
@simoneb simoneb changed the title Fix cli command name from starter to init Fix CLI command name from starter to init Sep 4, 2018
Copy link
Contributor

@jimmymintzer jimmymintzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simoneb simoneb merged commit 94dec4e into master Sep 4, 2018
@simoneb simoneb deleted the issue-122 branch September 4, 2018 14:37
ronandoolan2 pushed a commit that referenced this pull request Jul 30, 2021
Fix CLI command name from starter to init
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants