Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add missing conversions #22

Merged
merged 3 commits into from
Dec 17, 2022

Conversation

armano2
Copy link
Contributor

@armano2 armano2 commented Nov 23, 2021

add missing conversion for:

  • yarn create name -> npm init name and yarn init name -> npm create name
  • npm run x -- --args -> yarn x --args or yarn run x --args
  • npm ls abc bcd -> yarn list --pattern "abc|bcd"

fixes #21, fixes #8, fixes #7

cc: @slorber @Josh-Cena
ref: facebook/docusaurus#5635 facebook/docusaurus#5861 issue

@armano2 armano2 changed the title feat: add ls/why and create/init commands feat: add missing conversion Nov 23, 2021
@Josh-Cena
Copy link

Well, thanks, I'd hope that this PR gets merged but probably not any time soon (ref @nebrelbug's status). @slorber and I have probably settled on forking this library as his own so we can do some overhaul in it

@armano2
Copy link
Contributor Author

armano2 commented Nov 24, 2021

Well, thanks, I'd hope that this PR gets merged but probably not any time soon (ref @nebrelbug's status). @slorber and I have probably settled on forking this library as his own so we can do some overhaul in it

generally i would like to drop rolup form it, and make it module, add actual args parsing, and rebuild them, but for now i followed code style and i just added simple regexps, there is actually lots of edge cases that are not supported....

@Josh-Cena
Copy link

Yep, I tried forking & making some updates in the Docusaurus repo, but I was later informed that FB isn't particularly willing to maintain external deps and would rather keep them external. The implementation of this package differs significantly from my imagination🤦‍♂️

@armano2 armano2 changed the title feat: add missing conversion feat: add missing conversions Nov 24, 2021
@armano2 armano2 closed this Nov 25, 2021
@armano2 armano2 deleted the fix/add-missing-commands branch November 25, 2021 00:55
@armano2 armano2 restored the fix/add-missing-commands branch November 25, 2021 00:56
@armano2 armano2 reopened this Nov 25, 2021
@Josh-Cena
Copy link

@armano2 Your fork didn't have issues enabled so I'll just post the note here. I just spotted that npm start can't be converted: https://www.electronjs.org/docs/latest/tutorial/quick-start#run-the-main-process Above this heading, npm start fails to be converted.

slorber added a commit to facebook/docusaurus that referenced this pull request Feb 25, 2022
unfortunately npm2yarn does not remove it yet :(
requires nebrelbug/npm-to-yarn#22
@nebrelbug
Copy link
Owner

nebrelbug commented Dec 17, 2022

Since I just returned from my mission, I've finally had a chance to review this PR. It looks good, so I'll merge right now and publish a new release as version 1.2.0. Thanks so much for the good work!

I'll leave issue #8 open, since it appears not to be completely resolved (converting the examples given in the issue summary doesn't return the desired results).

@nebrelbug nebrelbug merged commit a4cbf19 into nebrelbug:master Dec 17, 2022
@nebrelbug
Copy link
Owner

@Josh-Cena @armano2 like you mentioned, this package is a bit hacky and would need a significant overhaul to be super reliable. The CI and build process should be updated as well.

I'm fairly busy right now, so I don't think I'm going to have time in the next few months to work on this package intensively. I would like to modernize the build process, but I may not have time for that either in the next few months. I'm happy to review issues and merge PRs, and will try to work on the package when I have time.

I already added @slorber as a contributor, and am happy to add either of you if you'd like -- and/or to explore options for transferring ownership.

@armano2
Copy link
Contributor Author

armano2 commented Dec 18, 2022

I actually progressed quiet far with fixing issues, I will submit additional pr

@nebrelbug
Copy link
Owner

@armano2 have you made any progress on the additional PR?

@armano2 armano2 deleted the fix/add-missing-commands branch February 12, 2023 08:41
@armano2
Copy link
Contributor Author

armano2 commented Feb 12, 2023

@armano2 have you made any progress on the additional PR?

@nebrelbug i forgot to push/commit my changes, PR submitted #36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants