LintGradleTask: revert listeners breaking change

nebula-plugins · Nov 27, 2023 · 451daa2 · 451daa2
1 parent 21ce7f3
commit 451daa2
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/src/main/groovy/com/netflix/nebula/lint/plugin/GradleLintPluginTaskConfigurer.groovy b/src/main/groovy/com/netflix/nebula/lint/plugin/GradleLintPluginTaskConfigurer.groovy
@@ -18,7 +18,7 @@ abstract class GradleLintPluginTaskConfigurer extends AbstractLintPluginTaskConf
             def autoLintTask = project.tasks.register(AUTO_LINT_GRADLE, LintGradleTask)
             autoLintTask.configure {
                 group = LINT_GROUP
-                listeners.set(lintExt.listeners)
+                listeners = lintExt.listeners
                 projectRootDir.set(project.rootDir)
                 notCompatibleWithConfigurationCache("Gradle Lint Plugin is not compatible with configuration cache because it requires project model")
             }

diff --git a/src/main/groovy/com/netflix/nebula/lint/plugin/LintGradleTask.groovy b/src/main/groovy/com/netflix/nebula/lint/plugin/LintGradleTask.groovy
@@ -31,7 +31,7 @@ import static com.netflix.nebula.lint.StyledTextService.Styling.*
 abstract class LintGradleTask extends DefaultTask {
     @Input
     @Optional
-    abstract ListProperty<GradleLintViolationAction> getListeners()
+    List<GradleLintViolationAction> listeners = []
 
     @Input
     @Optional
@@ -45,7 +45,6 @@ abstract class LintGradleTask extends DefaultTask {
     abstract Property<File> getProjectRootDir()
 
     LintGradleTask() {
-        listeners.convention([])
         failOnWarning.convention(false)
         onlyCriticalRules.convention(false)
         group = 'lint'
@@ -61,7 +60,7 @@ abstract class LintGradleTask extends DefaultTask {
         def violations = new LintService().lint(project, onlyCriticalRules.get()).violations
                 .unique { v1, v2 -> v1.is(v2) ? 0 : 1 }
 
-        (listeners.get() + new GradleLintPatchAction(project) + new GradleLintInfoBrokerAction(project) + consoleOutputAction).each {
+        (getListeners() + new GradleLintPatchAction(project) + new GradleLintInfoBrokerAction(project) + consoleOutputAction).each {
             it.lintFinished(violations)
         }
     }