Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added property osname to support AIX rpm. #328

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pradeepbansal00
Copy link

This is simply the porting of change which Brian Cox did on v3.2.1 version
( https://github.com/nebula-plugins/gradle-ospackage-plugin/compare/master...brc0x1:feature/osname?expand=1)

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 85.388% when pulling b78f71f on pradeepbansal00:v3.6.1 into 1bd9961 on nebula-plugins:master.

@aaltman
Copy link

aaltman commented Apr 29, 2019

Looks good, thanks @pradeepbansal00.

@mnellemann
Copy link

Is there any way this can be merged ?

@chali
Copy link
Member

chali commented May 19, 2021

Thank you for the contribution. Could you rebase the PR?

@mnellemann
Copy link

It looks like a lot of changes has been been made since this PR.

I have done some testing (id "nebula.ospackage" version "8.5.6") and tried to build an rpm for AIX with the following task in my build.gradle:

task buildRpmAix(type: Rpm) {
    dependsOn build, startShadowScripts
    packageName = 'jload-AIX'
    os = Os.AIX
    arch = Architecture.NOARCH
    type = RpmType.BINARY
}

When I try to install it on AIX 7.2, I get:

# rpm -i jload-AIX-1.1.3-1.noarch.rpm
        package jload-AIX-0:1.1.3-1.noarch is intended for a different operating system

I can use the --ignoreos flag, and it installs just fine (as a noarch package). But this I can also do with the rpm package build with os = Os.LINUX. Not sure what to make of this. My skills are not up to doing any major code changes, but I would like test or help otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants