Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prettier を3系の最新安定版に更新 #45

Merged
merged 2 commits into from
Jul 7, 2023

Conversation

keitakn
Copy link
Member

@keitakn keitakn commented Jul 7, 2023

issueURL

#44

この PR で対応する範囲 / この PR で対応しない範囲

#44 のDoneの定義を満たす実装は全てこのPR内で実施する。

Storybook の URL、 スクリーンショット

UI変更はないのでなし。

変更点概要

PRタイトルの通りPrettier を3系の最新安定版に更新。

@ianvs/prettier-plugin-sort-imports が動作しなくなってしまったが .prettierrc.json"plugins": ["@ianvs/prettier-plugin-sort-imports"], を明示的に指定するようにする事で正常に利用出来るようになった。

レビュアーに重点的にチェックして欲しい点

特になし

補足情報

特になし

@keitakn keitakn self-assigned this Jul 7, 2023
@vercel
Copy link

vercel bot commented Jul 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai-cat-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 7, 2023 3:47pm

@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (fcc1f2e) 100.00% compared to head (93f27fe) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #45   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           16        16           
  Lines           55        55           
  Branches         5         5           
=========================================
  Hits            55        55           
Impacted Files Coverage Δ
src/features/cat.ts 100.00% <ø> (ø)
src/mocks/api/internal/cats/mockFetchCatMessage.ts 100.00% <ø> (ø)
.../cats/mockFetchCatMessageUnexpectedResponseBody.ts 100.00% <ø> (ø)
src/utils/sleep.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@keitakn keitakn marked this pull request as ready for review July 7, 2023 15:52
@keitakn keitakn merged commit a9cb197 into main Jul 7, 2023
9 checks passed
@keitakn keitakn deleted the feature/issue44/upgrade-prettier branch July 7, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant