Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use os.UserHomeDir #1706

Merged
merged 2 commits into from Mar 31, 2023
Merged

Use os.UserHomeDir #1706

merged 2 commits into from Mar 31, 2023

Conversation

wolfogre
Copy link
Member

github.com/mitchellh/go-homedir is made for the old version. After go 1.12, there's os.UserHomeDir.

@wolfogre wolfogre requested a review from a team as a code owner March 28, 2023 08:15
@wolfogre
Copy link
Member Author

BTW, I don't know why act uses github.com/ZauberNerd/go-git, it still uses go-homedir while the upstream already dropped it:

go-git/go-git#535

@ZauberNerd
Copy link
Contributor

BTW, I don't know why act uses github.com/ZauberNerd/go-git, it still uses go-homedir while the upstream already dropped it:

go-git/go-git#535

We're using the fork because of this issue: go-git/go-git#485

@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Merging #1706 (a7ef941) into master (4989f44) will increase coverage by 1.64%.
The diff coverage is 74.55%.

@@            Coverage Diff             @@
##           master    #1706      +/-   ##
==========================================
+ Coverage   61.22%   62.87%   +1.64%     
==========================================
  Files          46       48       +2     
  Lines        7141     7482     +341     
==========================================
+ Hits         4372     4704     +332     
+ Misses       2462     2459       -3     
- Partials      307      319      +12     
Impacted Files Coverage Δ
pkg/container/docker_cli.go 82.23% <ø> (ø)
pkg/container/docker_logger.go 52.08% <ø> (ø)
pkg/container/docker_pull.go 33.33% <ø> (ø)
pkg/container/docker_run.go 14.08% <0.00%> (+0.49%) ⬆️
pkg/container/docker_volume.go 0.00% <ø> (ø)
pkg/container/file_collector.go 39.68% <0.00%> (+2.38%) ⬆️
pkg/container/host_environment.go 0.00% <0.00%> (ø)
pkg/exprparser/functions.go 66.32% <0.00%> (-1.04%) ⬇️
pkg/model/workflow.go 42.11% <ø> (ø)
pkg/model/planner.go 44.71% <21.27%> (-4.12%) ⬇️
... and 20 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ChristopherHX
Copy link
Contributor

Then we should also use os.UserConfigDir() instead of some third party lib for XDG etc.

@mergify mergify bot merged commit d3dfde0 into nektos:master Mar 31, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants