#502 Test for the improvement

nelmio · Jun 12, 2016 · 1256275 · 1256275
1 parent 725e4d9
commit 1256275
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 0 deletions.
diff --git a/Tests/Extractor/Handler/FosRestHandlerTest.php b/Tests/Extractor/Handler/FosRestHandlerTest.php
@@ -203,4 +203,22 @@ public function testWithRequestParamPlainArrayRequirements()
         $this->assertArrayHasKey('requirement', $filters['param1']);
         $this->assertEquals('NotNull, NotBlank', $filters['param1']['requirement']);
     }
+
+    public function testWithRequirementParamNotSet()
+    {
+        $container  = $this->getContainer();
+        $extractor  = $container->get('nelmio_api_doc.extractor.api_doc_extractor');
+        $annotation = $extractor->get('Nelmio\ApiDocBundle\Tests\Fixtures\Controller\TestController::zActionWithRequirementParamNotSet', 'test_route_31');
+
+        $this->assertNotNull($annotation);
+
+        $filters = $annotation->getFilters();
+        $this->assertCount(1, $filters);
+        $this->assertArrayHasKey('param1', $filters);
+        $filter = $filters['param1'];
+
+        $this->assertArrayNotHasKey('requirement', $filter);
+        $this->assertArrayHasKey('description', $filter);
+        $this->assertEquals($filter['description'], 'Param1 description.');
+    }
 }
diff --git a/Tests/Fixtures/Controller/TestController.php b/Tests/Fixtures/Controller/TestController.php
@@ -414,4 +414,12 @@ public function routeWithQueryParamArrayRequirementsAction()
     public function routeWithQueryParamPlainArrayRequirementsAction()
     {
     }
+
+    /**
+     * @ApiDoc()
+     * @QueryParam(name="param1", description="Param1 description.")
+     */
+    public function zActionWithRequirementParamNotSet()
+    {
+    }
 }
diff --git a/Tests/Fixtures/app/config/routing.yml b/Tests/Fixtures/app/config/routing.yml
@@ -248,3 +248,8 @@ test_route_30:
     path: /z-query-param-plain-array-requirements
     methods: [GET]
     defaults: { _controller: NelmioApiDocTestBundle:Test:routeWithQueryParamPlainArrayRequirementsAction }
+
+test_route_31:
+    path: /z-query-requirement-param-not-set
+    methods: [GET]
+    defaults: { _controller: NelmioApiDocTestBundle:Test:zActionWithRequirementParamNotSet }