Fix OpenApiRenderer list could be null (#1881)

Co-authored-by: Samael tomas <samael.tomas@wizbii.com>
nelmio · Oct 19, 2021 · efa83ca · efa83ca
1 parent 653a1f1
commit efa83ca
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/Render/RenderOpenApi.php b/Render/RenderOpenApi.php
@@ -26,10 +26,10 @@ class RenderOpenApi
     /** @var ContainerInterface */
     private $generatorLocator;
 
-    /** @var array<string, OpenApiRenderer> */
+    /** @var array<string, OpenApiRenderer|null> */
     private $openApiRenderers = [];
 
-    public function __construct(ContainerInterface $generatorLocator, OpenApiRenderer ...$openApiRenderers)
+    public function __construct(ContainerInterface $generatorLocator, ?OpenApiRenderer ...$openApiRenderers)
     {
         $this->generatorLocator = $generatorLocator;
         foreach ($openApiRenderers as $openApiRenderer) {

diff --git a/Tests/Render/RenderOpenApiTest.php b/Tests/Render/RenderOpenApiTest.php
@@ -48,6 +48,19 @@ public function testUnknownArea()
         $this->renderOpenApi();
     }
 
+    public function testNullFormat()
+    {
+        $openApiRenderer = $this->createMock(OpenApiRenderer::class);
+        $openApiRenderer->method('getFormat')->willReturn($this->format);
+        $openApiRenderer->expects($this->once())->method('render');
+
+        $availableOpenApiRenderers = [
+            $openApiRenderer,
+            null,
+        ];
+        $this->renderOpenApi(...$availableOpenApiRenderers);
+    }
+
     private function renderOpenApi(...$openApiRenderer): void
     {
         $spec = $this->createMock(OpenApi::class);