Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(#2264): adopt Conventional Commits #2273

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

chore(#2264): adopt Conventional Commits #2273

wants to merge 1 commit into from

Conversation

DominicLuidold
Copy link
Contributor

Q A
Bug fix? no
New feature? no
Deprecations? no
Issues Close #2264

@DjordyKoert
Copy link
Collaborator

While changing the approach, it may be beneficial to switch to using pull request title and description as default to use the PR's

FYI I have just updated the repo settings to use title + description.
I have also disabled direct pushes to master :)

@DjordyKoert
Copy link
Collaborator

hey @DominicLuidold is this PR ready? :)

@DominicLuidold
Copy link
Contributor Author

hey @DominicLuidold is this PR ready? :)

@DjordyKoert unfortunately not yet. The changes to the contributing guide are still a todo.

I won't be able to finish this PR until the end of May as I'm currently on a longer vacation. I hope that's fine!

@DjordyKoert
Copy link
Collaborator

@DominicLuidold no worries! I can also do it myself if my time allows it. Enjoy your vacation 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: Adopt Conventional Commits
2 participants
@DominicLuidold @DjordyKoert