Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect assets mode config in controller #2280

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Respect assets mode config in controller #2280

wants to merge 1 commit into from

Conversation

HypeMC
Copy link
Contributor

@HypeMC HypeMC commented Apr 24, 2024

Q A
Bug fix? yes
New feature? no
Deprecations? no
Issues -

Currently the SwaggerUiController doesn't respect the assets_mode configuration added in #2251.

nelmio_api_doc:
  html_config:
    assets_mode: cdn

As far as I can tell, there's no reason for the default any more as it can be set through the configuration and overridden in the DumpCommand command using the html-config option.

@HypeMC HypeMC force-pushed the fix-assets-mode-in-controller branch from 33b9cc4 to bd37679 Compare April 24, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deluxetom deluxetom deluxetom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@HypeMC @deluxetom