Make filters always be passed as query string parameters in sandbox requests #757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Scheduled for 2.12, thanks! |
|
I think line 477 in pull request is incorrect and should be: so have a look. |
|
Closing as I am not able to accept new features right now. |
|
@GuilhemN can we reopen this PR? |
|
Sure. I don't have time to review it but if you think it's ready to be merged I can merge it. |
|
ok .. I will test it out and give you feedback |
|
Ok, thanks ! |
|
hmm somehow I didn't manage to send a PR to this PR so I ended up creating a new PR with a tiny typo fix that was need to make things work #988 |
|
Fixed in #988 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in an issue of NelmioApiDocBundle, currently all filters are sent as POST parameters on non-GET requests in the sandbox.
I've modified the HTML templeate of the methods to be able to tell filters and parameters apart (method.html.twig) and added some code to the JavaScript making the ajax call, to append the filters to the URL if necessary.