Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #565 #792

Merged
merged 1 commit into from Feb 24, 2016
Merged

Fix #565 #792

merged 1 commit into from Feb 24, 2016

Conversation

rodrigm
Copy link
Contributor

@rodrigm rodrigm commented Jan 26, 2016

Fix #565


Required fields will be false for PATCH routes instead of PUT

@Padam87
Copy link
Contributor

Padam87 commented Jan 26, 2016

👍

@rodrigm
Copy link
Contributor Author

rodrigm commented Feb 19, 2016

Sorry, can you give feedback to this?

@willdurand
Copy link
Collaborator

Could you please squash your commits? thank you

Change PUT by PATCH

Refactor tests for nelmio#565
@rodrigm
Copy link
Contributor Author

rodrigm commented Feb 24, 2016

Done!

willdurand added a commit that referenced this pull request Feb 24, 2016
@willdurand willdurand merged commit 2a0f95e into nelmio:master Feb 24, 2016
@willdurand
Copy link
Collaborator

thank you!

@rodrigm
Copy link
Contributor Author

rodrigm commented Feb 24, 2016

👍

@joserobleda
Copy link

😍

@devantoine
Copy link

Doesn't seem to work as expected:

nelmiopatch

@rodrigm
Copy link
Contributor Author

rodrigm commented Apr 28, 2016

Are you in the correct version?

I've tested and worked fine

@devantoine
Copy link

I'm in 2.11 and I can see your edit in my vendors.

@rodrigm
Copy link
Contributor Author

rodrigm commented Apr 28, 2016

It's strange, be sure to delete cache, etc.

@devantoine
Copy link

Already did.

The input parameter is set to a form type, is it working with form types too?

@rodrigm
Copy link
Contributor Author

rodrigm commented Apr 28, 2016

Maybe, the form fields have priority

@devantoine
Copy link

That's it. If I use the entity as the input parameter all the fields requirement are set to false. But it's not possible with a FormType then?

@rodrigm
Copy link
Contributor Author

rodrigm commented Apr 28, 2016

I think also it should be well.

@devantoine
Copy link

devantoine commented Apr 28, 2016

So what am I missing here? Do you have to set all my form's fields to required => false?

@rodrigm
Copy link
Contributor Author

rodrigm commented Apr 28, 2016

No, I think being a PATCH should ignore the form and put all required => false

@devantoine
Copy link

So a new PR is needed right?

@rodrigm
Copy link
Contributor Author

rodrigm commented Apr 28, 2016

Yeah, it's a new issue/PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants