New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove default values for boolean nodes in paths config #186

Open

alexndlm wants to merge 1 commit into nelmio:master from alexndlm:feature/remove-default-values-for-path-config

alexndlm commented Apr 19, 2023

If we set a default value for the boolean nodes paths config, it always overrides the default value in the defaults section.

Imagine that we have the following config:

nelmio_cors:
    defaults:
        skip_same_as_origin: false
    paths:
        '^/':
            origin_regex: true
            allow_origin: ['^http://localhost:[0-9]+']

As a result, we will have skip_same_as_origin = true for the ^/ path. This is not expected behaviour.


          feature/remove-default-values-for-path-config

49bdcad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment