Fix returned empty arguments when args are passed via func_get_args (#…

…1047)

Closes #1046

fixtures/Entity/DummyWithNoArgumentConstructor.php

@@ -0,0 +1,35 @@
+<?php
+
+/*
+ * This file is part of the Alice package.
+ *
+ * (c) Nelmio <hello@nelm.io>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
+namespace Nelmio\Alice\Entity;
+
+class DummyWithNoArgumentConstructor
+{
+    /**
+     * @var array
+     */
+    private $args;
+
+    public function __construct()
+    {
+        $this->args = func_get_args();
+    }
+
+    /**
+     * @return array
+     */
+    public function getArgs(): array
+    {
+        return $this->args;
+    }
+}

src/Generator/NamedArgumentsResolver.php

@@ -27,6 +27,10 @@ public function resolveArguments(array $arguments, string $className, string $me
             return $arguments;
         }
 
+        if (0 === count($method->getParameters())) {
+            return $arguments;
+        }
+
         $sortedArguments = [];
         $buffer = [];
 

tests/Generator/NamedArgumentsResolverTest.php

@@ -13,6 +13,7 @@
 
 namespace Nelmio\Alice\Generator;
 
+use Nelmio\Alice\Entity\DummyWithNoArgumentConstructor;
 use Nelmio\Alice\Entity\DummyWithMethods;
 use Nelmio\Alice\Entity\EmptyDummy;
 use PHPUnit\Framework\TestCase;
@@ -302,6 +303,19 @@ public function provideResolveArgumentsCases()
                 'bar2' => null,
             ],
         ];
+
+        yield 'with arguments passed to a constructor that does not expect arguments' => [
+            DummyWithNoArgumentConstructor::class,
+            '__construct',
+            [
+                'foo',
+                'bar',
+            ],
+            [
+                'foo',
+                'bar',
+            ],
+        ];
     }
 
     public function testThrowsExceptionWhenResolvingUnknownArguments(): void