Skip to content
This repository has been archived by the owner on Sep 3, 2021. It is now read-only.

Remove spaces from generated scopes #258

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mayrmax
Copy link

@mayrmax mayrmax commented May 31, 2019

Generated scopes contain a space in their name.
By standard scopes are sent to the backend as a space separated list.
See RFC 6749

This change removes the spaces from generated scopes and allows standard handling by existing libraries.

This breaking change as old scopes would not work anymore.


I'm not sure how others handled this I saw some solutions that separate scopes by colons but this would make it standard compatible.

@codecov-io
Copy link

codecov-io commented May 31, 2019

Codecov Report

Merging #258 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #258   +/-   ##
=======================================
  Coverage   94.47%   94.47%           
=======================================
  Files           4        4           
  Lines         326      326           
=======================================
  Hits          308      308           
  Misses         18       18

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72e3276...9d83de9. Read the comment docs.

@michaeldgraham
Copy link
Collaborator

#608

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants