This repository has been archived by the owner on Dec 24, 2020. It is now read-only.
Feed isort from stdin (#225) #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexd2580
changed the title
alexd2580
changed the title
alexd2580
changed the title
alexd2580
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR
isortwill be fed the current buffer content from stdin.Previously, when runnign
isortthe file content would be read from disc,meaning that running it on a dirty buffer would break the edited file, since the
diff generated by
isortwould not match the file.In the same fashion, running
isortmultiple times would also break the file.By always feeding the current buffer content to
isort, you get wysiwyg behavior.This PR requires isort to be of version 5.5.2
For reference see: PyCQA/isort#1469
Closes #225