Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump eslint-plugin-jest #1

Merged
merged 2 commits into from Jun 24, 2019
Merged

Bump eslint-plugin-jest #1

merged 2 commits into from Jun 24, 2019

Conversation

MarkPolivchuk
Copy link
Contributor

To avoid issues in 22.6

@MarkPolivchuk MarkPolivchuk requested a review from iansu June 21, 2019 17:44
@iansu
Copy link
Member

iansu commented Jun 21, 2019

I ran into this issue earlier but a new version hadn't been released yet. Have you tested this locally using yarn resolutions?

@MarkPolivchuk
Copy link
Contributor Author

MarkPolivchuk commented Jun 21, 2019 •
edited

I symlinked this branch and re-ran yarn and it seemed to work after restarting eslint

@MarkPolivchuk
Copy link
Contributor Author

Confirmed, eslint crashes using eslint-plugin-jest@22.6.2, eslint-plugin-jest@22.7.0 does not.

@MarkPolivchuk MarkPolivchuk merged commit fdc05cf into master Jun 24, 2019
@MarkPolivchuk MarkPolivchuk deleted the bump-jest-plugin branch June 24, 2019 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iansu iansu iansu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MarkPolivchuk @iansu