Simplify config event posting logic (remove ConfigConfig) #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
embeddedt
reviewed
Jan 17, 2024
| postConfigEvent(ModConfigEvent.Reloading::new); | ||
| } | ||
|
|
||
| void postConfigEvent(Function<ModConfig, ? extends ModConfigEvent> constructor) { |
There was a problem hiding this comment.
I'd suggest making this synchronized for now as a stop-gap to prevent Loading and Reloading from firing concurrently. (Unless we have fixed that problem already.)
There was a problem hiding this comment.
I think I see the problem, and I have an idea to fix it. I'd like to leave it for another PR though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Events are not on the game layer component anymore, we can instantiate them directly from the config logic. 馃槈