[1.20.6] Add KnownPacks for mods #901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sciwhiz12
added
enhancement
sciwhiz12
previously requested changes
May 1, 2024
src/main/java/net/neoforged/neoforge/event/AddPackFindersEvent.java
Outdated
Show resolved
Hide resolved
tests/src/main/java/net/neoforged/neoforge/oldtest/world/LoginPacketSplitTest.java
Outdated
Show resolved
Hide resolved
src/main/java/net/neoforged/neoforge/resource/ResourcePackLoader.java
Outdated
Show resolved
Hide resolved
patches/net/minecraft/server/network/config/SynchronizeRegistriesTask.java.patch
Outdated
Show resolved
Hide resolved
|
|
Matyrobbrt
requested changes
May 4, 2024
tests/src/main/java/net/neoforged/neoforge/debug/resources/BulkKnownPackTest.java
Outdated
Show resolved
Hide resolved
tests/src/main/java/net/neoforged/neoforge/debug/resources/BulkKnownPackTest.java
Outdated
Show resolved
Hide resolved
|
In order to guarantee sensible syncing of known packs, this PR now includes the mod IDs and versions of every mod in a mod file in the pack name and KnownPack for this file -- if we don't do this, we could end up with situations where, say, two mods are in the same file on one end and different files on another end and stuff gets synced via knownpack that is not discoverable via knownpack. I have also updated the system to add knownpacks to packs created by the utility TelepathicGrunt added to AddPackFindersEvent, which adds packs from subfolders of the mod. |
Matyrobbrt
requested changes
May 11, 2024
patches/net/minecraft/client/multiplayer/KnownPacksManager.java.patch
Outdated
Show resolved
Hide resolved
src/main/java/net/neoforged/neoforge/event/AddPackFindersEvent.java
Outdated
Show resolved
Hide resolved
Matyrobbrt
approved these changes
May 12, 2024
CodexAdrian
added a commit
to CodexAdrian/NeoForge
that referenced
this pull request
May 21, 2024
commit 8ac9f9c Author: Minecraftschurli <minecraftschurli@gmail.com> Date: Tue May 21 15:25:59 2024 +0200 [Testframework] Fix wrapping GameTestAssertException (neoforged#988) commit 66197fe Author: Max <max@someone.ky> Date: Sat May 18 20:11:00 2024 +0200 Add a Fluid Ingredient system as an analogue to vanilla's Ingredient (neoforged#789) commit b1c3fe0 Author: NeoForged Localizations <machine-l10n@neoforged.net> Date: Sun May 19 00:43:32 2024 +0800 New Crowdin updates (neoforged#972) commit a7edbae Author: Sara Freimer <sara@freimer.com> Date: Fri May 17 01:32:34 2024 -0500 Implement equals and hashCode for SizedIngredients (neoforged#965) commit e9e8af0 Author: Dennis C <xfacthd@gmx.de> Date: Fri May 17 08:31:55 2024 +0200 [1.20.6] Use extensible enum codec and streamcodec for rarity enum (neoforged#958) commit 986e0e3 Author: TelepathicGrunt <40846040+TelepathicGrunt@users.noreply.github.com> Date: Fri May 17 02:28:12 2024 -0400 Patch in missing LivingJumpEvent for Slime and Camel (neoforged#966) commit 2bf3073 Author: TelepathicGrunt <40846040+TelepathicGrunt@users.noreply.github.com> Date: Fri May 17 02:26:49 2024 -0400 Pass growing plant blockstate into onCropsGrowPre for various vine blocks (neoforged#967) commit 0033435 Author: embeddedt <42941056+embeddedt@users.noreply.github.com> Date: Fri May 17 02:25:24 2024 -0400 Fix ComputeCameraAngles event applying roll in global space (neoforged#968) commit bb3537b Author: TelepathicGrunt <40846040+TelepathicGrunt@users.noreply.github.com> Date: Wed May 15 23:02:02 2024 -0400 [no ci] Remove PitcherCrop patch TODO (neoforged#963) commit d80f154 Author: TelepathicGrunt <40846040+TelepathicGrunt@users.noreply.github.com> Date: Wed May 15 23:01:36 2024 -0400 [no ci] Fixed Bubble Column gametest template size (neoforged#964) commit c888a68 Author: Luke Bemish <lukebemish@lukebemish.dev> Date: Wed May 15 01:29:03 2024 -0500 [1.20.6] Add KnownPacks for mods (neoforged#901) commit a28986f Author: shartte <shartte@users.noreply.github.com> Date: Mon May 13 09:13:19 2024 +0200 Update FML to 3.0.29 (neoforged#957) commit 2aadb61 Author: TelepathicGrunt <40846040+TelepathicGrunt@users.noreply.github.com> Date: Sat May 11 14:11:06 2024 -0400 Make StructureTemplate's Palette caches thread safe (neoforged#954) commit 2bced72 Author: TelepathicGrunt <40846040+TelepathicGrunt@users.noreply.github.com> Date: Sat May 11 13:49:18 2024 -0400 Address POI memory leak and Generate Command issues (neoforged#937) Co-authored-by: embeddedt <42941056+embeddedt@users.noreply.github.com> commit abc54b7 Author: Sirttas <Sirttas@users.noreply.github.com> Date: Sat May 11 19:48:09 2024 +0200 [Test Framework] Add a check in `StructureTemplateBuilder#set` to prevent placing block outside template bondaries (neoforged#950) commit 2d93ce5 Author: embeddedt <42941056+embeddedt@users.noreply.github.com> Date: Sat May 11 01:28:34 2024 -0400 Delete ItemModelShaper patch (neoforged#952) commit 018e104 Author: embeddedt <42941056+embeddedt@users.noreply.github.com> Date: Fri May 10 19:58:05 2024 -0400 Fix more particle culling issues (neoforged#951) commit 03e346b Author: TelepathicGrunt <40846040+TelepathicGrunt@users.noreply.github.com> Date: Fri May 10 12:14:37 2024 -0400 Fix MC-268617 to allow valid filepaths in Minecraft (neoforged#767) commit fe57823 Author: TelepathicGrunt <40846040+TelepathicGrunt@users.noreply.github.com> Date: Fri May 10 12:02:54 2024 -0400 Fire Villager/Wandering Trader trade events on /reload (neoforged#922) commit d0ed10a Author: TelepathicGrunt <40846040+TelepathicGrunt@users.noreply.github.com> Date: Fri May 10 12:02:04 2024 -0400 Remove Unnecessary Stitcher patch (neoforged#948) commit a598489 Author: Matyrobbrt <65940752+Matyrobbrt@users.noreply.github.com> Date: Fri May 10 14:44:48 2024 +0300 Bump Mixin to 0.13.4 to fix local variable issues (neoforged#945) Fixes neoforged#768 commit 212f760 Author: sciwhiz12 <arnoldnunag12@gmail.com> Date: Fri May 10 10:29:47 2024 +0800 Fix dedicated server GUI never showing up (neoforged#946) commit 238a273 Author: embeddedt <42941056+embeddedt@users.noreply.github.com> Date: Thu May 9 17:07:08 2024 -0400 Add more accurate culling for single quad particles (neoforged#885) commit 27c5d7a Author: Brennan Ward <Bward7864@gmail.com> Date: Thu May 9 10:50:55 2024 -0700 Fix FinalizeSpawnEvent for trial spawners and fix SpawnGroupData propagation (neoforged#880) Closes neoforged#783 Closes neoforged#939 commit 989ed3b Author: TelepathicGrunt <40846040+TelepathicGrunt@users.noreply.github.com> Date: Thu May 9 13:40:34 2024 -0400 [1.20.6] Fix several NeoForge command crashes and allow chat OpenFile click action on Integrated Server (neoforged#915)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
KnownPacks for mod data packs, and allows packs added withAddPackFindersEventwithKnownPacks to actually be used. This has two benefits:KnownPacks for mods are identified by the mod ID and version.