Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow modded ArmorMaterial implementations for override_armor_materials on trim materials #663

Open
wants to merge 1 commit into
base: 1.20.x
Choose a base branch
from
Open

Allow modded ArmorMaterial implementations for override_armor_materials on trim materials #663

wants to merge 1 commit into from

Conversation

TJT01
Copy link

@TJT01 TJT01 commented Feb 26, 2024

Notes for Vanilla <-> NeoForge connections:

  • NeoForge Server, Vanilla Client: Seems to work from limited testing.
  • Vanilla Server, NeoForge Client: Works fine.

@neoforged-pr-publishing
Copy link

  • Publish PR to GitHub Packages

@XFactHD
Copy link
Member

XFactHD commented Feb 28, 2024

It might make sense to hold off on this as 1.20.5 makes armor materials a registry, which completely alleviates the issue this PR tries to solve.

@Matyrobbrt Matyrobbrt added enhancement New (or improvement to existing) feature or request 1.20 Targeted at Minecraft 1.20 data driven This request involves a data driven system labels Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.20 Targeted at Minecraft 1.20 data driven This request involves a data driven system enhancement New (or improvement to existing) feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@TJT01 @XFactHD @Matyrobbrt