Add error if spawn placements are missing for entities that spawn in-world #689
+32
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an error in dev if there are any entities added to the
MobSpawnSettingsfor biomes and the entity does not register a spawn placement. The reason for this is that if you do not register a spawn placement the entity can spawn anywhere which includes in the are and is usually a bug 99.9% of the time and can be hard to track down if a developer does not know where to look and does not know they need to register to such an event this logging will help with such an issue and help prevent such bug from reaching production. If a developer does need to not have their entities restricted they can register with NO_RESTRICTIONS as what vanilla does if none is registered is just default toNO_RESTRICTIONSand always true for the predicate.