-
-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.20.4] Add BlockDropsEvent
#788
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shadows-of-Fire
previously requested changes
Apr 7, 2024
src/main/java/net/neoforged/neoforge/event/level/BlockEvent.java
Outdated
Show resolved
Hide resolved
src/main/java/net/neoforged/neoforge/event/level/BlockEvent.java
Outdated
Show resolved
Hide resolved
src/main/java/net/neoforged/neoforge/event/level/BlockEvent.java
Outdated
Show resolved
Hide resolved
src/main/java/net/neoforged/neoforge/event/level/BlockEvent.java
Outdated
Show resolved
Hide resolved
Shadows-of-Fire
added
enhancement
New (or improvement to existing) feature or request
1.20.4
Targeted at Minecraft 1.20.4
labels
Apr 7, 2024
There is value in moving the XP logic completely out of |
…to be spawned, instead of a immutable list of ItemStacks.
Shadows-of-Fire
changed the title
Added a BlockDestroyed Event
[1.20.4] Add Apr 8, 2024
BlockDropsEvent
1.20.4 is now in feature freeze, so this will be pushed to 1.20.5; though it works out well enough, since the XP changes can be made in one pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
BlockDropsEvent
, which fires after the drops for a block have been determined but before they have been added to the world.This allows for manipulation of the item entities, which is not possible when using loot modifiers (they can only change the list of item stacks).
Cancellation of the event causes no items to be dropped, but the block will remain destroyed/replaced by air. During the next breaking change window, we can also migrate the XP logic from
BreakEvent
to this event, as this is hooked in where XP is normally dropped, which will reduce patch overhead.This PR also adds a
breakBlock
method to the GameTest helper to simulate breaking blocks with an entity and tool within a game test.