[20.6] RenderType changes #842
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
I'm not against this change in principle but the AT looks like an absolute chore to maintain. |
|
The ATs should be autogenerated. |
|
Rebased onto latest 20.6 changes |
|
Replying to: Technici4n
Unsure how you would go about having the ATs be autogenerated? |
marchermans
reviewed
May 7, 2024
marchermans
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR marks all commonly used
RenderType/RenderStateShardfields/classes/methods as public, allowing modders to make custom render types easier, without needing to AT themselves or extendRenderTypeto access theprotected staticfieldsWith this change
NeoForgeRenderTypes.Internalhas been updated to no longer extendRenderType, this is to validate that the AT has been applied and continues to be applied in future updates.