Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge EventHooks into CommonHooks #875

Draft
wants to merge 1 commit into
base: 1.20.x
Choose a base branch
from

Conversation

Technici4n
Copy link
Member

@Technici4n Technici4n commented Apr 27, 2024

The split is a bit artificial. Might as well have all the "misc hooks" in a single class.

Draft until #588 is merged.

@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Apr 27, 2024

  • Publish PR to GitHub Packages

Last commit published: f48f0a227d9e7001c8206cd85341ec0fc131a0f8.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #875' // https://github.com/neoforged/NeoForge/pull/875
        url 'https://prmaven.neoforged.net/NeoForge/pr875'
        content {
            includeModule('net.neoforged', 'neoforge')
            includeModule('net.neoforged', 'testframework')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr875.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr875
cd NeoForge-pr875
curl -L https://prmaven.neoforged.net/NeoForge/pr875/net/neoforged/neoforge/20.5.17-beta-pr-875-merge-event-common-hooks/mdk-pr875.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

@Technici4n Technici4n marked this pull request as draft April 27, 2024 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant