Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add c:indestructible and c:shulker_boxes tags #942

Closed
wants to merge 5 commits into from
Closed

Add c:indestructible and c:shulker_boxes tags #942

wants to merge 5 commits into from
+53 −0

Conversation

Spinoscythe
Copy link
Contributor

@Spinoscythe Spinoscythe commented May 8, 2024 •
edited

Fabric PR for c:indestructible: FabricMC/fabric#3758
c:shulker_boxes already in Fabric

Fixes #941
Fixes #894

@neoforged-pr-publishing
Copy link

  • Publish PR to GitHub Packages

@Spinoscythe Spinoscythe mentioned this pull request May 8, 2024
Closed
@Spinoscythe Spinoscythe changed the title Add indestructible and shulker_boxes tags Add c:indestructible and c:shulker_boxes tags May 9, 2024
Matyrobbrt
Matyrobbrt requested changes May 9, 2024
View reviewed changes
Copy link
Member

@Matyrobbrt Matyrobbrt left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this PR made alongside a Fabric issue or PR? We are not going to merge it until then, and until that PR is approved.

@Spinoscythe
Copy link
Contributor Author

@Matyrobbrt yes there is: FabricMC/fabric#3758

@Matyrobbrt Matyrobbrt added enhancement New (or improvement to existing) feature or request data driven This request involves a data driven system 1.20.6 Targeted at Minecraft 1.20.6 labels May 15, 2024
@TelepathicGrunt
Copy link
Sponsor Contributor

@Spinoscythe Could you remove the indestructable tag from this pr? We can merge in the shulker box work. The indestructable tag may need more discussion about it separately

@Spinoscythe
Copy link
Contributor Author

will do when I come back

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marchermans marchermans marchermans approved these changes

@Matyrobbrt Matyrobbrt Awaiting requested review from Matyrobbrt

Assignees
No one assigned
Labels
1.20.6 Targeted at Minecraft 1.20.6 data driven This request involves a data driven system enhancement New (or improvement to existing) feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add c:indestructible tag Convention tag requests
4 participants
@Spinoscythe @TelepathicGrunt @marchermans @Matyrobbrt