Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.20.6] Use extensible enum codec and streamcodec for rarity enum #958

Merged
merged 1 commit into from
May 17, 2024

Conversation

XFactHD
Copy link
Member

@XFactHD XFactHD commented May 12, 2024

This PR fixes the Rarity enum (which is made extensible by NeoForge) using the wrong Codec and StreamCodec and crashing when a non-vanilla rarity is encountered.

@XFactHD XFactHD added bug A bug or error 1.20.6 Targeted at Minecraft 1.20.6 labels May 12, 2024
@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented May 12, 2024

  • Publish PR to GitHub Packages

Last commit published: bb2374957e22305195117b85f502ad50038a6288.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #958' // https://github.com/neoforged/NeoForge/pull/958
        url 'https://prmaven.neoforged.net/NeoForge/pr958'
        content {
            includeModule('net.neoforged', 'testframework')
            includeModule('net.neoforged', 'neoforge')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr958.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr958
cd NeoForge-pr958
curl -L https://prmaven.neoforged.net/NeoForge/pr958/net/neoforged/neoforge/20.6.63-beta-pr-958-rarity_enum_codec/mdk-pr958.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

@FiniteReality
Copy link
Member

Changes seem fine as-is; all it needs is rebasing onto the latest 1.20.x commit and it should be good to merge.

@marchermans marchermans merged commit e9e8af0 into neoforged:1.20.x May 17, 2024
5 checks passed
@XFactHD XFactHD deleted the rarity_enum_codec branch May 18, 2024 14:50
CodexAdrian added a commit to CodexAdrian/NeoForge that referenced this pull request May 21, 2024
commit 8ac9f9c
Author: Minecraftschurli <minecraftschurli@gmail.com>
Date:   Tue May 21 15:25:59 2024 +0200

    [Testframework] Fix wrapping GameTestAssertException (neoforged#988)

commit 66197fe
Author: Max <max@someone.ky>
Date:   Sat May 18 20:11:00 2024 +0200

    Add a Fluid Ingredient system as an analogue to vanilla's Ingredient (neoforged#789)

commit b1c3fe0
Author: NeoForged Localizations <machine-l10n@neoforged.net>
Date:   Sun May 19 00:43:32 2024 +0800

    New Crowdin updates (neoforged#972)

commit a7edbae
Author: Sara Freimer <sara@freimer.com>
Date:   Fri May 17 01:32:34 2024 -0500

    Implement equals and hashCode for SizedIngredients (neoforged#965)

commit e9e8af0
Author: Dennis C <xfacthd@gmx.de>
Date:   Fri May 17 08:31:55 2024 +0200

    [1.20.6] Use extensible enum codec and streamcodec for rarity enum (neoforged#958)

commit 986e0e3
Author: TelepathicGrunt <40846040+TelepathicGrunt@users.noreply.github.com>
Date:   Fri May 17 02:28:12 2024 -0400

    Patch in missing LivingJumpEvent for Slime and Camel (neoforged#966)

commit 2bf3073
Author: TelepathicGrunt <40846040+TelepathicGrunt@users.noreply.github.com>
Date:   Fri May 17 02:26:49 2024 -0400

    Pass growing plant blockstate into onCropsGrowPre for various vine blocks (neoforged#967)

commit 0033435
Author: embeddedt <42941056+embeddedt@users.noreply.github.com>
Date:   Fri May 17 02:25:24 2024 -0400

    Fix ComputeCameraAngles event applying roll in global space (neoforged#968)

commit bb3537b
Author: TelepathicGrunt <40846040+TelepathicGrunt@users.noreply.github.com>
Date:   Wed May 15 23:02:02 2024 -0400

    [no ci] Remove PitcherCrop patch TODO (neoforged#963)

commit d80f154
Author: TelepathicGrunt <40846040+TelepathicGrunt@users.noreply.github.com>
Date:   Wed May 15 23:01:36 2024 -0400

    [no ci] Fixed Bubble Column gametest template size (neoforged#964)

commit c888a68
Author: Luke Bemish <lukebemish@lukebemish.dev>
Date:   Wed May 15 01:29:03 2024 -0500

    [1.20.6] Add KnownPacks for mods (neoforged#901)

commit a28986f
Author: shartte <shartte@users.noreply.github.com>
Date:   Mon May 13 09:13:19 2024 +0200

    Update FML to 3.0.29 (neoforged#957)

commit 2aadb61
Author: TelepathicGrunt <40846040+TelepathicGrunt@users.noreply.github.com>
Date:   Sat May 11 14:11:06 2024 -0400

    Make StructureTemplate's Palette caches thread safe (neoforged#954)

commit 2bced72
Author: TelepathicGrunt <40846040+TelepathicGrunt@users.noreply.github.com>
Date:   Sat May 11 13:49:18 2024 -0400

    Address POI memory leak and Generate Command issues (neoforged#937)

    Co-authored-by: embeddedt <42941056+embeddedt@users.noreply.github.com>

commit abc54b7
Author: Sirttas <Sirttas@users.noreply.github.com>
Date:   Sat May 11 19:48:09 2024 +0200

    [Test Framework] Add a check in `StructureTemplateBuilder#set` to prevent placing block outside template bondaries (neoforged#950)

commit 2d93ce5
Author: embeddedt <42941056+embeddedt@users.noreply.github.com>
Date:   Sat May 11 01:28:34 2024 -0400

    Delete ItemModelShaper patch (neoforged#952)

commit 018e104
Author: embeddedt <42941056+embeddedt@users.noreply.github.com>
Date:   Fri May 10 19:58:05 2024 -0400

    Fix more particle culling issues (neoforged#951)

commit 03e346b
Author: TelepathicGrunt <40846040+TelepathicGrunt@users.noreply.github.com>
Date:   Fri May 10 12:14:37 2024 -0400

    Fix MC-268617 to allow valid filepaths in Minecraft (neoforged#767)

commit fe57823
Author: TelepathicGrunt <40846040+TelepathicGrunt@users.noreply.github.com>
Date:   Fri May 10 12:02:54 2024 -0400

    Fire Villager/Wandering Trader trade events on /reload (neoforged#922)

commit d0ed10a
Author: TelepathicGrunt <40846040+TelepathicGrunt@users.noreply.github.com>
Date:   Fri May 10 12:02:04 2024 -0400

    Remove Unnecessary Stitcher patch (neoforged#948)

commit a598489
Author: Matyrobbrt <65940752+Matyrobbrt@users.noreply.github.com>
Date:   Fri May 10 14:44:48 2024 +0300

    Bump Mixin to 0.13.4 to fix local variable issues (neoforged#945)

    Fixes neoforged#768

commit 212f760
Author: sciwhiz12 <arnoldnunag12@gmail.com>
Date:   Fri May 10 10:29:47 2024 +0800

    Fix dedicated server GUI never showing up (neoforged#946)

commit 238a273
Author: embeddedt <42941056+embeddedt@users.noreply.github.com>
Date:   Thu May 9 17:07:08 2024 -0400

    Add more accurate culling for single quad particles (neoforged#885)

commit 27c5d7a
Author: Brennan Ward <Bward7864@gmail.com>
Date:   Thu May 9 10:50:55 2024 -0700

    Fix FinalizeSpawnEvent for trial spawners and fix SpawnGroupData propagation (neoforged#880)

    Closes neoforged#783
    Closes neoforged#939

commit 989ed3b
Author: TelepathicGrunt <40846040+TelepathicGrunt@users.noreply.github.com>
Date:   Thu May 9 13:40:34 2024 -0400

    [1.20.6] Fix several NeoForge command crashes and allow chat OpenFile click action on Integrated Server  (neoforged#915)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.20.6 Targeted at Minecraft 1.20.6 bug A bug or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants