Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hopefully fix google text result images #30

Merged
merged 3 commits into from
May 16, 2024

Conversation

lukebemish
Copy link
Contributor

@lukebemish lukebemish commented Feb 11, 2024

So you know how neoforge's search results seem to show random images as the thumbnail image? Sometimes curle's profile picture, sometimes tech's? This hopefully fixes this, using the thumbnail meta documented here. (This meta is just for google custom search engines, it seems - let's see if the og:image tag helps stuff instead). It's hard for me to actually test, unfortunately.


Preview URL: https://pr-30.neoforged-website-previews.pages.dev

@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-website-previews (Preview) February 11, 2024 19:48 Active
@neoforged-pages-deployments
Copy link

neoforged-pages-deployments bot commented Feb 11, 2024

Deploying with Cloudflare Pages

Name Result
Last commit: 6f2a417324fb965ae996b729e69590405729b0bf
Status: ✅ Deploy successful!
Preview URL: https://251e764d.neoforged-website-previews.pages.dev
PR Preview URL: https://pr-30.neoforged-website-previews.pages.dev

@lukebemish lukebemish marked this pull request as draft February 11, 2024 19:51
@lukebemish
Copy link
Contributor Author

Need to do some more reading - those docs appear to only be for google custom search engines, so I need to check and figure out whether it applies to normal google search results too. Converting to a draft for now

@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-website-previews (Preview) February 11, 2024 23:30 Active
@lukebemish lukebemish changed the title Add thumbnail meta Hopefully fix google text result images Feb 11, 2024
@lukebemish
Copy link
Contributor Author

Alright, decided to approach this instead with the og:image meta tag, and making sure that gets set - I also changed around the title of the main page to communicate the fact that this is the home page for the neoforged project, cause I noticed that being strange in embed cards.

@lukebemish lukebemish marked this pull request as ready for review February 11, 2024 23:34
@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-website-previews (Preview) February 11, 2024 23:37 Active
@UltimatChamp
Copy link
Contributor

Wouldn't this work:
Screenshot_20240322_204744

@lukebemish
Copy link
Contributor Author

Wouldn't this work:
Screenshot_20240322_204744

Could work I suppose; seems like the brute force approach, but yeah, we could just force google to not index the profile images at all. Not sure if that would hit search rankings though

Copy link
Member

@sciwhiz12 sciwhiz12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not quite sure what the effects of this will be, since this would only really be visible after merging and waiting for Google to catch up.

In light of that, I'm merging this with a note that we should revisit this in a month or so, to see what its effects are.

@sciwhiz12 sciwhiz12 merged commit c4495cb into neoforged:main May 16, 2024
1 check passed
@lukebemish lukebemish deleted the thumbnail branch May 16, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants