Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5102 onRowClick add altKey, ctrlKey, metaKey, shiftKey tests and fires #5120

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

gplanansky
Copy link

What kind of change does this PR introduce? (check at least one)

George Planansky added 3 commits December 1, 2023 08:30
…eta or shift keys were down, it also fires ('select/deselect', {record}). App listeners can check the rowclick data object for MouseEvent properties. Select/deselect listeners work as before.
@gplanansky
Copy link
Author

The code is now modified to handles both type "click" and type "dblclick"

  • handling dblclick is optional, controlled by the config parameter: "dblclickEnable" . The default value of false preserves old behavior.
  • all clicks fire "rowclick"
  • pure click also does row highligting and fires "select" or "deselect", identical to the old behavior
  • distinguishing clicks from a dblclick is via a setTimeout that waits "dblclickDelay" ms to test if dblclick has been detected. The configurable dblclickDelay is 510. A better way would be welcome.

@gplanansky gplanansky closed this Dec 3, 2023
@gplanansky gplanansky reopened this Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant