Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plain data objects #493

Merged
merged 19 commits into from May 14, 2020
Merged

Plain data objects #493

merged 19 commits into from May 14, 2020

Commits on Feb 20, 2020

  1. napi: add test for a plain object

    @goto-bus-stop
    goto-bus-stop committed Feb 20, 2020
    Configuration menu
    Copy the full SHA
    42dc3a9 View commit details
    Browse the repository at this point in the history

  2. implement empty_object()

    @goto-bus-stop
    goto-bus-stop committed Feb 20, 2020
    Configuration menu
    Copy the full SHA
    071b1da View commit details
    Browse the repository at this point in the history

  3. Implement Object#set()

    @goto-bus-stop
    goto-bus-stop committed Feb 20, 2020
    Configuration menu
    Copy the full SHA
    e2a75c1 View commit details
    Browse the repository at this point in the history

  4. Implement Object#get()

    @goto-bus-stop
    goto-bus-stop committed Feb 20, 2020
    Configuration menu
    Copy the full SHA
    70f15f8 View commit details
    Browse the repository at this point in the history

  5. Implement required tag checks for the object test

    @goto-bus-stop
    goto-bus-stop committed Feb 20, 2020
    Configuration menu
    Copy the full SHA
    3508034 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2020

  1. Implement Object#get_own_property_names()

    @goto-bus-stop
    goto-bus-stop committed Feb 21, 2020
    Configuration menu
    Copy the full SHA
    6526dd3 View commit details
    Browse the repository at this point in the history

  2. Implement Array#len

    @goto-bus-stop
    goto-bus-stop committed Feb 21, 2020
    Configuration menu
    Copy the full SHA
    89bb88f View commit details
    Browse the repository at this point in the history

  3. Implement Object#get_index

    @goto-bus-stop
    goto-bus-stop committed Feb 21, 2020
    Configuration menu
    Copy the full SHA
    c4fb9fd View commit details
    Browse the repository at this point in the history

  4. Implement is_string tag

    @goto-bus-stop
    goto-bus-stop committed Feb 21, 2020
    Configuration menu
    Copy the full SHA
    65d6d24 View commit details
    Browse the repository at this point in the history

  5. Remove is_a_compat, used in one place

    @goto-bus-stop
    goto-bus-stop committed Feb 21, 2020
    Configuration menu
    Copy the full SHA
    6bca181 View commit details
    Browse the repository at this point in the history

  6. Implement Object#set_index

    @goto-bus-stop
    goto-bus-stop committed Feb 21, 2020
    Configuration menu
    Copy the full SHA
    a22e512 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2020

  1. Only import Env if it is used

    @goto-bus-stop
    goto-bus-stop committed Mar 1, 2020
    Configuration menu
    Copy the full SHA
    0a31cc2 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2020

  1. Merge branch 'master' into objects

    @goto-bus-stop
    goto-bus-stop committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    23abcc7 View commit details
    Browse the repository at this point in the history

  2. Document panics for neon_runtime::napi::array::len

    @goto-bus-stop
    goto-bus-stop committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    a4c5a3c View commit details
    Browse the repository at this point in the history

  3. Document out param in neon_runtime::nan::object::set_{index,string}.

    @goto-bus-stop
    goto-bus-stop committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    ff8a4f2 View commit details
    Browse the repository at this point in the history

  4. Document the implemented neon_runtime::napi functions.

    @goto-bus-stop
    goto-bus-stop committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    55700eb View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2020

  1. Stringify elements of napi_get_property_names.

    @goto-bus-stop
    goto-bus-stop committed Apr 8, 2020
    Configuration menu
    Copy the full SHA
    c1fbddc View commit details
    Browse the repository at this point in the history

  2. Filter it down to own properties.

    @goto-bus-stop
    goto-bus-stop committed Apr 8, 2020
    Configuration menu
    Copy the full SHA
    f6b1c4f View commit details
    Browse the repository at this point in the history

  3. Check hasOwnProperty after conversion to string 

    I thought I could be clever and micro-optimize this a bit, but
`has_own_property` really does require a string argument, so we have to
do the conversion first.
    @goto-bus-stop
    goto-bus-stop committed Apr 8, 2020
    Configuration menu
    Copy the full SHA
    9b338f9 View commit details
    Browse the repository at this point in the history