Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Function calls #507

Merged
merged 23 commits into from
Jun 20, 2020
Merged

Function calls #507

merged 23 commits into from
Jun 20, 2020

Commits on May 24, 2020

  1. Add env parameter to invoke() API

    @goto-bus-stop
    goto-bus-stop committed May 24, 2020
    Configuration menu
    Copy the full SHA
    1ac73a6 View commit details
    Browse the repository at this point in the history

  2. Make CallbackInfo wrap a pointer.

    @goto-bus-stop
    goto-bus-stop committed May 24, 2020
    Configuration menu
    Copy the full SHA
    6d5c32a View commit details
    Browse the repository at this point in the history

  3. Unwrap v8::External pointer in C++ 

    napi automatically wraps and unwraps the `data` pointer on functions
created through `napi_create_function`, so we don't need to use the
`napi_create_external` API in neon-runtime. Instead we can work with the
raw pointers. This aligns the C++ and n-api APIs so that the `neon`
crate can just assume associated data for a function is always a raw
pointer.
    @goto-bus-stop
    goto-bus-stop committed May 24, 2020
    Configuration menu
    Copy the full SHA
    cfc8940 View commit details
    Browse the repository at this point in the history

  4. Start work on exporting n-api functions

    @goto-bus-stop
    goto-bus-stop committed May 24, 2020
    Configuration menu
    Copy the full SHA
    98462ae View commit details
    Browse the repository at this point in the history

  5. napi: Implement receiving call arguments on the Rust side.

    @goto-bus-stop
    goto-bus-stop committed May 24, 2020
    Configuration menu
    Copy the full SHA
    f61b739 View commit details
    Browse the repository at this point in the history

  6. napi: implement return value 

    napi expects you to return a `napi_value` from your functions, instead
of using `SetReturn` like in nan. I ended up having to duplicate these
`invoke` implementations after all!
    @goto-bus-stop
    goto-bus-stop committed May 24, 2020
    Configuration menu
    Copy the full SHA
    a0ec71b View commit details
    Browse the repository at this point in the history

  7. Start porting function tests from nan to n-api runtime.

    @goto-bus-stop
    goto-bus-stop committed May 24, 2020
    Configuration menu
    Copy the full SHA
    dfebfc6 View commit details
    Browse the repository at this point in the history

  8. Start porting object test to n-api runtime.

    @goto-bus-stop
    goto-bus-stop committed May 24, 2020
    Configuration menu
    Copy the full SHA
    8d00d71 View commit details
    Browse the repository at this point in the history

  9. Implement runtime::fun::call.

    @goto-bus-stop
    goto-bus-stop committed May 24, 2020
    Configuration menu
    Copy the full SHA
    546f2ce View commit details
    Browse the repository at this point in the history

  10. Implement runtime::fun::construct.

    @goto-bus-stop
    goto-bus-stop committed May 24, 2020
    Configuration menu
    Copy the full SHA
    440e5f9 View commit details
    Browse the repository at this point in the history

  11. Implement is_object tag check.

    @goto-bus-stop
    goto-bus-stop committed May 24, 2020
    Configuration menu
    Copy the full SHA
    1835acf View commit details
    Browse the repository at this point in the history

  12. Implement runtime::fun::this().

    @goto-bus-stop
    goto-bus-stop committed May 24, 2020
    Configuration menu
    Copy the full SHA
    10495c4 View commit details
    Browse the repository at this point in the history

  13. Enable other passing this tests.

    @goto-bus-stop
    goto-bus-stop committed May 24, 2020
    Configuration menu
    Copy the full SHA
    f4adc5b View commit details
    Browse the repository at this point in the history

  14. Remove outdated comments.

    @goto-bus-stop
    goto-bus-stop committed May 24, 2020
    Configuration menu
    Copy the full SHA
    0738432 View commit details
    Browse the repository at this point in the history

  15. Add test for get_own_property_names.

    @goto-bus-stop
    goto-bus-stop committed May 24, 2020
    Configuration menu
    Copy the full SHA
    b7e52e1 View commit details
    Browse the repository at this point in the history

  16. Check that get_own_property_names does not return Symbols

    @goto-bus-stop
    goto-bus-stop committed May 24, 2020
    Configuration menu
    Copy the full SHA
    3b4de37 View commit details
    Browse the repository at this point in the history

  17. Remove possibly-incorrect handling of Rust panics in callback

    @goto-bus-stop
    goto-bus-stop committed May 24, 2020
    Configuration menu
    Copy the full SHA
    d9e3324 View commit details
    Browse the repository at this point in the history

  18. Add a lifetime parameter to CallbackInfo

    @goto-bus-stop
    goto-bus-stop committed May 24, 2020
    Configuration menu
    Copy the full SHA
    d25fe61 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2020

  1. kick ci

    @goto-bus-stop
    goto-bus-stop committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    a488204 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2020

  1. Remove unnecessary argc value from neon_runtime::call::data().

    @goto-bus-stop
    goto-bus-stop committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    5281247 View commit details
    Browse the repository at this point in the history

  2. try to explain why we unwrap the external

    @goto-bus-stop
    goto-bus-stop committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    e31c16c View commit details
    Browse the repository at this point in the history

  3. do a capitalisation

    @goto-bus-stop
    goto-bus-stop committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    7213332 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2020

  1. reference TODO issue

    @goto-bus-stop
    goto-bus-stop committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    0a40f6a View commit details
    Browse the repository at this point in the history