Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

safekeeper: move is_cancelled to write_shared_state. #7687

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

arssher
Copy link
Contributor

@arssher arssher commented May 10, 2024

Each time we access shared state we either want to error out if it is cancelled or ignore that; make that explicit.

Each time we access shared state we either want to error out if it is cancelled
or ignore that; make that explicit.
@arssher arssher requested a review from a team as a code owner May 10, 2024 04:05
@arssher arssher requested a review from petuhovskiy May 10, 2024 04:05
Copy link

3024 tests run: 2891 passed, 0 failed, 133 skipped (full report)


Flaky tests (1)

Postgres 14

  • test_secondary_background_downloads: debug

Code coverage* (full report)

  • functions: 31.4% (6319 of 20136 functions)
  • lines: 47.3% (47617 of 100708 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
5e650c8 at 2024-05-10T04:50:21.670Z :recycle:

@petuhovskiy
Copy link
Member

I don't understand why is it better.

@arssher
Copy link
Contributor Author

arssher commented May 13, 2024

It enforces checking for cancelled timeline: each time you lock it, you must think whether to allow cancelled or not. Also, with more modes which disallow access (paused in next pr, probably evicted timelines) it also becomes less verbose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants