-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Postgres 14.12, 15.7, and 16.3 updates #7688
Conversation
@hlinnaka I didn't do the merge strategy because I think we should unsquash the v15 and v16 branches, though it seemed to work when I tried it out. |
3102 tests run: 2975 passed, 0 failed, 127 skipped (full report)Flaky tests (5)Postgres 16
Postgres 15
Postgres 14
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
98aba0a at 2024-05-20T16:41:33.682Z :recycle: |
39b2694
to
9f45419
Compare
dc22fb8
to
f457b90
Compare
f8e989d
to
cb39039
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per the discussion at #7688 (comment), let's:
- keep the test for an unlogged index, and
- add an explicit test for an unlogged sequence.
With those changes, LGTM.
PS. Thanks for the very thorough comment on the history of unlogged sequences, that's very helpful!
Tristan pointed on slack that that has been addressed.
This would still be nice for clarity, but not essential. The test does cover unlogged sequences as it is |
Some files may have known differences that we are okay with.
Previously we worked around file comparison issues by dropping unlogged relations in the pg_regress tests, but this would lead to an unnecessary diff when compared to upstream in our Postgres fork. Instead, we can precompute the files that we know will be different, and ignore them.
cb39039
to
58f0552
Compare
58f0552
to
621c8f7
Compare
Unlogged sequences were added in v15, so let's just test to make sure they work on Neon.
621c8f7
to
98aba0a
Compare
No description provided.