safekeeper: implement timeline pause #7711
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arssher
requested review from
jcsp and
petuhovskiy
and removed request for
a team and
jcsp
2886 tests run: 2760 passed, 6 failed, 120 skipped (full report)Failures on Postgres 16Failures on Postgres 15Failures on Postgres 14Flaky tests (2)Postgres 16
Postgres 14
Test coverage report is not availableThe comment gets automatically updated with the latest test results
c5412b3 at 2024-05-13T12:47:10.998Z :recycle: |
jcsp
reviewed
May 13, 2024
So far it immediately stops only writes to the timeline, which is already might be useful.
petuhovskiy
reviewed
May 13, 2024
| @@ -20,7 +20,7 @@ use utils::{bin_ser::LeSer, id::TenantTimelineId}; | |||
| use crate::SafeKeeperConf; | |||
|
|
|||
| pub const SK_MAGIC: u32 = 0xcafeceefu32; | |||
| pub const SK_FORMAT_VERSION: u32 = 8; | |||
| pub const SK_FORMAT_VERSION: u32 = 9; | |||
There was a problem hiding this comment.
This is a forward incompatible change and it is still annoying.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far it immediately stops only writes to the timeline, which is already might be useful.