safekeeper: log LSNs on connection exit #7728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3078 tests run: 2951 passed, 0 failed, 127 skipped (full report)Flaky tests (2)Postgres 16
Postgres 14
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
01ed082 at 2024-05-20T12:26:33.649Z :recycle: |
petuhovskiy
reviewed
May 17, 2024
petuhovskiy
reviewed
May 17, 2024
petuhovskiy
approved these changes
May 17, 2024
We can't gracefully exit COPY mode (and don't need that), so close connection to prevent further attempts to use it.
Useful for observability.
arssher
force-pushed
the
sk-conns-log-lsns
branch
from
6d83a27
to
01ed082
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages.
closes #7621