Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI(report-benchmarks-failures): fix condition #7745

Merged
merged 1 commit into from
May 14, 2024

Conversation

bayandin
Copy link
Member

@bayandin bayandin commented May 13, 2024

Problem

report-benchmarks-failures job is triggered for any failure in the CI pipeline, but we need it to be triggered only for failed benchmarks job

Summary of changes

  • replace failure() with needs.benchmarks.result == 'failure' in the condition

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

Copy link

3060 tests run: 2927 passed, 0 failed, 133 skipped (full report)


Code coverage* (full report)

  • functions: 31.4% (6333 of 20177 functions)
  • lines: 47.3% (47872 of 101172 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
3f61ea9 at 2024-05-13T18:40:52.577Z :recycle:

@bayandin bayandin enabled auto-merge (squash) May 14, 2024 10:32
@bayandin bayandin merged commit b6ee918 into main May 14, 2024
58 checks passed
@bayandin bayandin deleted the bayandin/fix-benchmark-reporting branch May 14, 2024 10:40
a-masterov pushed a commit that referenced this pull request May 20, 2024
## Problem

`report-benchmarks-failures` job is triggered for any failure in the CI
pipeline, but we need it to be triggered only for failed `benchmarks`
job

## Summary of changes
- replace `failure()` with `needs.benchmarks.result == 'failure'` in the
condition
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants