Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(dockerls): document ignoreMultilineInstructions setting #3142

Merged
merged 1 commit into from May 7, 2024

Conversation

fho
Copy link
Contributor

@fho fho commented May 7, 2024

Document how the ignoreMultilineInstructions settings for dockerls can
be configured.

That the settings key must be "docker" instead of "dockerls" makes it
non-intuitive and harder to figure out.

Sources:

@fho fho requested a review from glepnir as a code owner May 7, 2024 10:50
@fho fho marked this pull request as draft May 7, 2024 10:55
Document how the ignoreMultilineInstructions settings for dockerls can
be configured.

That the settings key must be "docker" instead of "dockerls" makes it
non-intuitive and harder to figure out.

Sources:
- https://github.com/rcjsuen/dockerfile-language-server?tab=readme-ov-file#language-server-settings
- https://github.com/rcjsuen/dockerfile-language-server/blob/9e3f8580f711e54a1de0351631baeac49665d6f3/src/server.ts#L330-L344
@fho
Copy link
Contributor Author

fho commented May 7, 2024

I'm struggling with the commitlint check:

  • It complains that the URLs in the commit message exceed the max line length. It does not make sense to break those URLs into multiple lines though.
  • I don't understand the warning footer must have leading blank line [footer-leading-blank] I have a newline before "Sources:" which I would consider to be the footer

@glepnir how can I solve this?

@fho fho changed the title doc/dockerls: document ignoreMultilineInstructions setting docs(dockerls): document ignoreMultilineInstructions setting May 7, 2024
@fho fho marked this pull request as ready for review May 7, 2024 11:06
@glepnir
Copy link
Member

glepnir commented May 7, 2024

commit lint.. i can force update it no worry.

@glepnir glepnir merged commit c3957f8 into neovim:master May 7, 2024
8 of 9 checks passed
@fho fho deleted the doc_dockerls branch May 7, 2024 11:18
@fho
Copy link
Contributor Author

fho commented May 7, 2024

@glepnir thank you!

Feel-ix-343 pushed a commit to Feel-ix-343/nvim-lspconfig that referenced this pull request May 19, 2024
…3142)

Document how the ignoreMultilineInstructions settings for dockerls can
be configured.

That the settings key must be "docker" instead of "dockerls" makes it
non-intuitive and harder to figure out.

Sources:
- https://github.com/rcjsuen/dockerfile-language-server?tab=readme-ov-file#language-server-settings
- https://github.com/rcjsuen/dockerfile-language-server/blob/9e3f8580f711e54a1de0351631baeac49665d6f3/src/server.ts#L330-L344
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants