Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing APIs to be enabled in the documentation #121

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

estebanbouza
Copy link

@estebanbouza estebanbouza commented Mar 26, 2024

Added missing APIs that are required when setting up a new environment with the documentation steps.

Copy link
Contributor

nephio-prow bot commented Mar 26, 2024

Hi @estebanbouza. Thanks for your PR.

I'm waiting for a nephio-project member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

netlify bot commented Mar 26, 2024

Deploy Preview for nephio ready!

Name Link
🔨 Latest commit d6a7f34
🔍 Latest deploy log https://app.netlify.com/sites/nephio/deploys/66022316549f5a00085c4905
😎 Deploy Preview https://deploy-preview-121--nephio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@arora-sagar
Copy link
Contributor

Hi @efiacor Thanks for this PR. Did you test end to end on GCP? The rest of the content in the document is still valid?

@liamfallon
Copy link
Member

/ok-to-test

@liamfallon
Copy link
Member

@electrocucaracha and @arora-sagar are you happy to pull this one in?

@arora-sagar
Copy link
Contributor

@liamfallon Yeah go ahead.

@electrocucaracha
Copy link
Member

/lgtm
Maybe it requires to rebase it

@johnbelamaric
Copy link
Member

/approve

Copy link
Contributor

nephio-prow bot commented Apr 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnbelamaric

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label Apr 16, 2024
@efiacor
Copy link
Contributor

efiacor commented Apr 16, 2024

/easycla

Copy link

CLA Not Signed

@liamfallon
Copy link
Member

/retest

@liamfallon
Copy link
Member

Hi @estebanbouza , would you be able to look into the CLA? Once that's done, we can merge this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants