Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De duplication logic to NF Deploy Fn Param Ref (#494) #525

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aakashchan
Copy link
Contributor

Solves #493
These changes will ensure we have nf deploy fn to apply de dupulication logic to NF Deploy Param Ref

  1. Changes to Add Dependency to check if it already exist before adding. Thanks @gvbalaji for the code snippet in chat.
  2. Added test cases to handle dependency, if same file is present multiple times. Its not in our use case, but its better to add that too.
  3. Added changes to pipeline tests to ensure, if I run the NF Deploy Fn multiples after that, it doesn't break the idempotency principle.

These changes will ensure we have nf deploy fn to apply de dupulication
logic to NF Deploy Param Ref

1. Changes to Add Dependency to check if it already exist before adding.
Thanks @gvbalaji for the code snippet in chat.
2. Added test cases to handle dependency, if same file is present
multiple times. Its not in our use case, but its better to add that too.
3. Added changes to pipeline tests to ensure, if I run the NF Deploy Fn
multiples after that, it doesn't break the idempotency principle.


Docker image I used for testing -
[docker.io/lostbrain/nfdeployfn:test-5](http://docker.io/lostbrain/nfdeployfn:test-5)
Copy link
Contributor

nephio-prow bot commented Feb 14, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign s3wong for approval by writing /assign @s3wong in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

nephio-prow bot commented Feb 14, 2024

Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages.

The list of commits with invalid commit messages:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@efiacor
Copy link
Contributor

efiacor commented Apr 17, 2024

Hi @aakashchan , is this change still relevant?

@tliron
Copy link

tliron commented May 22, 2024

@aakashchan bump :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants