Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Developer Env Setup script: add more automation steps #44

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

kispaljr
Copy link
Contributor

@kispaljr kispaljr commented May 8, 2024

This depends on #43

Automate even more steps of the tutorial: https://github.com/nephio-project/porch/tree/main/docs/tutorials/porch-development-environment.

New Steps added:

  • generate certificates and keys required to run the end-to-end tests
  • WIP...

@nephio-prow nephio-prow bot requested review from henderiw and tliron May 8, 2024 08:40
Copy link
Contributor

nephio-prow bot commented May 8, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kispaljr
Once this PR has been reviewed and has the lgtm label, please assign s3wong for approval by writing /assign @s3wong in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


popd || exit
############################################
h1 Generate certs and keys
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you not prefer to patch this into #43

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure. I just wanted to keep new "features" (steps) separate from the refactor part. but I don't mind at all to merge the two.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Up to you. I did run this PR locally and the makekeys executes but I don't see the certs anywhere.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, that is actually a bug. I fixed it below

@kispaljr
Copy link
Contributor Author

/title Developer Env Setup script: add more automation steps

@kispaljr kispaljr changed the title Developer Env Setup script: add certs and keys generation step Developer Env Setup script: add more automation steps May 13, 2024
@kispaljr kispaljr requested a review from liamfallon May 13, 2024 16:33
- make the setup script rely on local config files instead of remote ones from github
- keep gitea deployment kpt package in .build directory (as opposed to a temp dir) in order to keep the local inventory for future updates
- vscode: remove kpt-related folders from workspace
- vscode: adopt porch-server launch paremeters to the porch components running in the test kind cluster
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants