New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Developer Env Setup script: add more automation steps #44
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kispaljr The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
||
popd || exit | ||
############################################ | ||
h1 Generate certs and keys |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you not prefer to patch this into #43
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure. I just wanted to keep new "features" (steps) separate from the refactor part. but I don't mind at all to merge the two.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Up to you. I did run this PR locally and the makekeys executes but I don't see the certs anywhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, that is actually a bug. I fixed it below
/title Developer Env Setup script: add more automation steps |
… for unit tests to run successfully
- make the setup script rely on local config files instead of remote ones from github - keep gitea deployment kpt package in .build directory (as opposed to a temp dir) in order to keep the local inventory for future updates - vscode: remove kpt-related folders from workspace - vscode: adopt porch-server launch paremeters to the porch components running in the test kind cluster
…h the go-client module
604ec1f
to
8aa0e94
Compare
This depends on #43
Automate even more steps of the tutorial: https://github.com/nephio-project/porch/tree/main/docs/tutorials/porch-development-environment.
New Steps added: