Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more attributes to SplatFacto #2880

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

maturk
Copy link
Collaborator

@maturk maturk commented Feb 7, 2024

For custom models, we need to access some of the intermediate outputs. Lets make them attributes so its easier to call outputs = super(SplatFacto).get_outputs(camera) and still have access to them.

@maturk maturk requested a review from kerrj February 8, 2024 11:06
@kerrj
Copy link
Collaborator

kerrj commented Feb 21, 2024

This is a good idea, but its quite a messy interface since there's so many mutable effects within the get_outputs. I wonder if we should just return them as a payload in the outputs dict?

@maturk
Copy link
Collaborator Author

maturk commented Mar 1, 2024

@kerrj, does it make sense to put intermediates in the output dict, since then the viser viewer will try to visualize them as well? Actually, I am thinking that all outputs from project_gaussians depths, radii, conics, and num_tiles_hit should be easily accessible since we need them for any additional calls to rasterize_gaussians (e.g. if the user wants to rasterize some additional feats or normals etc).

@jb-ye
Copy link
Collaborator

jb-ye commented Apr 30, 2024

Not entirely related to this PR, but I am thinking if we can leverage this TensorDataclass interface to manage intermediate variables and their slicing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants