Floater removal tool for splatfacto #3001
Conversation
nerfstudio/models/splatfacto.py
Outdated
| @@ -393,7 +503,10 @@ def after_train(self, step: int): | |||
| with torch.no_grad(): | |||
| # keep track of a moving average of grad norms | |||
| visible_mask = (self.radii > 0).flatten() | |||
| assert self.xys.grad is not None | |||
| try: | |||
There was a problem hiding this comment.
change to if self.xys.grad is None: return
| # Create the button with the modified callback | ||
| self.button2 = ViewerButton("Delete Gaussians", cb_hook=delete_cropbox) | ||
|
|
||
| def select_gaussians(button: ViewerButton): |
There was a problem hiding this comment.
Can we make both select_gaussians and delete_cropbox class functions? Will declutter the populate modules function
nerfstudio/models/splatfacto.py
Outdated
| self.selected_gaussian_indices = [] | ||
| self.original_colors = None | ||
|
|
||
| def update_colors(self): |
There was a problem hiding this comment.
I think this function is self-contained enough that it can be defined inside on_select, that way its scope is clearer (it only gets used inside that callback).
nerfstudio/models/splatfacto.py
Outdated
| @@ -186,6 +186,29 @@ def __init__( | |||
| ): | |||
| self.seed_points = seed_points | |||
| super().__init__(*args, **kwargs) | |||
| self.selected_gaussian_indices = [] | |||
There was a problem hiding this comment.
Let's define these inside populate_submodules next to the buttons/viewer control so all the new code for initializing floater removal is in one place
kerrj
changed the title
| camera = camera.to(self.device) | ||
|
|
||
| self.eval() | ||
| self.get_outputs_for_camera(camera) |
There was a problem hiding this comment.
can surround this in a with torch.no_grad()
There was a problem hiding this comment.
Oh i meant the get_outputs_for_camera() line
|
Hi! Thanks for your contribution! Any chance the changes will make it (PR)? |
No description provided.