Fix SH #3010
Open
Fix SH #3010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just to cite Inria gaussian splatting's implenentation: https://github.com/graphdeco-inria/gaussian-splatting/blob/main/utils/sh_utils.py |
|
Inria’s impl us also correct. The ingp’s one, however, supports more degrees. |
kerrj
reviewed
Mar 22, 2024
| @@ -31,7 +31,8 @@ def test_sh_renderer(): | |||
| levels = 4 | |||
| num_samples = 10 | |||
|
|
|||
| sh = torch.ones((3, num_samples, 3 * levels**2)) | |||
| sh = torch.zeros((3, num_samples, 3 * levels**2)) | |||
| sh[..., 0] = 3.6 | |||
There was a problem hiding this comment.
what is this for? maybe add a comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think there is a bug in the SH pytorch impl. This PR should fix it. Please take a look to see if it's correct. I took the correct implementation from ingp.