RFC: Universal Asset Notation #335
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doitian
reviewed
Apr 29, 2022
rfcs/0000-universal-asset-notation/0000-universal-asset-notation.md
Outdated
Show resolved
Hide resolved
| - `<chain-symbol>` is a lower-case abbreviation of the source chain where the asset resided before came through the path, e.g. `eth` for the Ethereum chain, `ckb` for the CKB chain. Note the source chain may be different from the issuance chain of the asset. | ||
| - `<bridge-symbol>` is a lower-case abbreviation of the bridge through which the asset came, e.g. `fb` for assets moved by Forcebridge. | ||
|
|
||
| Examples: |
There was a problem hiding this comment.
The method of translating | to via and . to from helps readers to understand the notation and read the symbol in human language. I think it worths a section here.
There was a problem hiding this comment.
Could you suggest the change with a PR?
rfcs/0000-universal-asset-notation/0000-universal-asset-notation.md
Outdated
Show resolved
Hide resolved
…on.md Co-authored-by: ian <me@iany.me>
e00dan
previously approved these changes
May 5, 2022
Flouse
suggested changes
Jun 29, 2022
rfcs/0000-universal-asset-notation/0000-universal-asset-notation.md
Outdated
Show resolved
Hide resolved
rfcs/0000-universal-asset-notation/0000-universal-asset-notation.md
Outdated
Show resolved
Hide resolved
…on.md Co-authored-by: Flouse <flouse@gmail.com>
…on.md Co-authored-by: Flouse <flouse@gmail.com>
Flouse
reviewed
Jul 1, 2022
rfcs/0000-universal-asset-notation/0000-universal-asset-notation.md
Outdated
Show resolved
Hide resolved
…on.md Co-authored-by: Flouse <flouse@gmail.com>
Flouse
approved these changes
Jul 1, 2022
homura
reviewed
Jul 4, 2022
| - `<path>` is a pair of bridge symbol and chain symbol, connected by a single dot `.`. | ||
| - `<asset-symbol>` is a upper-case abbreviation of the asset, e.g. `BTC` for bitcoin, `CKB` for CKByte. | ||
| - `<chain-symbol>` is a lower-case abbreviation of the source chain where the asset resided before came through the path, e.g. `eth` for the Ethereum chain, `ckb` for the CKB chain. Note the source chain may be different from the issuance chain of the asset. | ||
| - `<bridge-symbol>` is a lower-case abbreviation of the bridge through which the asset came, e.g. `fb` for assets moved by Forcebridge. |
There was a problem hiding this comment.
maybe "Forcebridge" should be written as "Force Bridge"
| - `<asset>` is the first component of UAN. It is a pair of `<asset-symbol>` and `<chain-symbol>` connected by a dot `.`, e.g. `BTC.ckb` for bitcoin resides on the CKB chain, `CKB.gw` for CKByte resides on the Godwoken chain. | ||
| - `<route>` is the route through which the asset come to Nervos Network, it's the second component of UAN. `<route>` is only required when the asset's chain of residence is different from its chain of issuance. `<route>` may consist of one or many `<path>`. If it's a multi-paths route, all paths are connected by `|`. | ||
| - `<path>` is a pair of bridge symbol and chain symbol, connected by a single dot `.`. | ||
| - `<asset-symbol>` is a upper-case abbreviation of the asset, e.g. `BTC` for bitcoin, `CKB` for CKByte. |
There was a problem hiding this comment.
The asset symbol should not be case restricted, since some ERC20 do have a lowercase symbol, like stETH (staked ETH), and some wrapped tokens, like wETH, wMANA
2 tasks
Keith-CY
added a commit
to Magickbase/godwoken_explorer
that referenced
this pull request
Jul 5, 2022
1. use display name instead of token name 2. use uan instead of symbol Ref: nervosnetwork/rfcs#335
Keith-CY
reviewed
Jul 6, 2022
|
|
||
| ``` | ||
| // CKByte on the CKB chain | ||
| CKB.ckb |
There was a problem hiding this comment.
So CKB in CKB DApps should be renamed to CKB.ckb? or we can make a convention that <asset-symbol> without any annotation indicates that it is born on the current chain backing the DApp.
|
Officially confirmed |
jimzk
reviewed
Jul 7, 2022
rfcs/0000-universal-asset-notation/0000-universal-asset-notation.md
Outdated
Show resolved
Hide resolved
Flouse
suggested changes
Aug 1, 2022
rfcs/0000-universal-asset-notation/0000-universal-asset-notation.md
Outdated
Show resolved
Hide resolved
rfcs/0000-universal-asset-notation/0000-universal-asset-notation.md
Outdated
Show resolved
Hide resolved
rfcs/0000-universal-asset-notation/0000-universal-asset-notation.md
Outdated
Show resolved
Hide resolved
…on.md Co-authored-by: Flouse <flouse@gmail.com>
…on.md Co-authored-by: Flouse <flouse@gmail.com>
…on.md Co-authored-by: Flouse <flouse@gmail.com>
…e-asset-list-reference Update the referenced forcebridge asset list url
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview Link