Update spawn syscalls #436
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix typo
Add deadlock state
xxuejie
previously approved these changes
Apr 25, 2024
xxuejie
reviewed
Apr 29, 2024
xxuejie
reviewed
Apr 29, 2024
|
|
||
| ### Spawn example | ||
| - If the Writer writes W bytes and the Reader reads R bytes where W > R, the Writer will block, and the Reader will return immediately with R bytes in `*length`. The Reader can then call `ckb_read` again to read the remaining W - R bytes. | ||
| - If the Writer writes W bytes and the Reader reads R bytes where W <= R, both the Writer and the Reader will return immediately with W bytes in `*length`. |
There was a problem hiding this comment.
I do recommend that we include more cases here, for example: if a VM tries to read from a channel, but no other VM writes to that channel, will the VM reading data hang there? Or will there be early return in some cases? We should really cover all those cases.
There was a problem hiding this comment.
Added two scenarios about hang. Scenarios about writing or reading from a closed fd are introduced in ckb_close.
xxuejie
reviewed
Apr 29, 2024
xxuejie
reviewed
May 6, 2024
Descriptions have been added about the number of vm, the number of instantied vm and the number of pipes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for ckb: nervosnetwork/ckb#4380