Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no error handling for inlineCss #740

Merged
merged 1 commit into from Jan 21, 2022
Merged

Conversation

lsheva
Copy link

@lsheva lsheva commented Jan 21, 2022

The absence of error handling for inlineCss was causing UnhandledPromiseRejection for invalid template CSS.

Example of incorrect template that was causing the issue: https://gist.github.com/lsheva/b882e889191eebec92a290a115f75aa6

Fixes #416

DOM was added to libs in tsconfig.json due to issue with Axios during build.

@juandav juandav merged commit 65669dd into nest-modules:master Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UnhandledPromiseRejection if email incorrect inside try..catch
2 participants